PDA

View Full Version : "rn" being deleted


RestlessThoughts
04-20-2016, 09:14 PM
The format function is stripping out "rn" from words.
The format function is stripping out "rn" causing words like "learn" to be displayed as "lea". Obviously, that's super annoying. I believe the original intention was to remove new line artifacts from text.

This is the problematic function:

private function format($text){
$text = html_entity_decode($text);
$text = stripslashes($text);
$text = str_replace("rn","",$text);
return $text;
}
Another issue with this is that it's repeated in four different files, more if you use mods like the news add on. So I suggest downloading an editor like Sublime Text 3, opening the folder with your site and using "Find in Files" to find all instances so it can be fixed. For the easiest fix I suggest simply deleting the line:
$text = str_replace("rn","",$text);

So far I haven't noticed excess "rn"s anyway. But if you're afraid of that, here's a corrected function that will strip new lines without stripping the letters "rn" from words.

private function format($text){
$text = html_entity_decode($text);
$text = str_replace("\r\n","",$text);
$text = stripslashes($text);
return $text;
}
In the base script you can find this function in the following files:
admincp\content.php
classes\class_messagecontainer.php
classes\class_privatemessage.php
inc\ckeditor_init.php

Abronsyth
04-22-2016, 09:23 PM
*tosses confetti into the air*

Amazing! I have been dying for a fix for this for ages now, I am absolutely delighted that someone found one!

tahbikat
04-22-2016, 11:38 PM
Ahh thank you! <3

Hall of Famer
08-17-2020, 11:32 PM
This has been fixed and will not occur again in Mys v1.3.5. For users on older versions, just use RestlessThoughts' solution then.