Mysidia Adoptables Support Forum - Mysidia Adoptables v1.3.1[Security Release]

Mysidia Adoptables Support Forum (http://www.mysidiaadoptables.com/forum/index.php)

- Mysidia Adoptables Official Announcement (http://www.mysidiaadoptables.com/forum/forumdisplay.php?f=2)

- - Mysidia Adoptables v1.3.1[Security Release] (http://www.mysidiaadoptables.com/forum/showthread.php?t=3571)

Oh wait a sec what is this about? The glitch you have after trying to manipulate the register.php and login.php files?

No. This is a fresh install without modifying the files.

Oh a fresh install? I believe the problem is not with the script since I've installed/upgraded the script on my dev demo server for many times and never had problem leveling up/clicking adoptables.

Edit:
I visited your site and tested the levelup.php myself on one of your pets. It worked perfectly, as I was able to click it at the first time and then receive an error message when I try to click again:
http://oi44.tinypic.com/n680np.jpg

So yeah, I have no idea why it was being mean to you. XD

Well no matter who's pets I click on, I've already leveled them up.

I see what you mean, I registered an account on your site and once I click one adoptable, I will not be able to click any others and instead receive the error message saying I've leveled them up. Again this is strange as I never had the issue on my two demo sites, are you sure this is a fresh installation? I just did a fresh installation and did not have this problem. Anyway I will ask other members and see if they have the same problem as well. Thanks for bringing it up.

Quote:

Originally Posted by Hall of Famer (Post 22686)

Thank you so much, I wasnt aware of this css issue since the main theme never had any of them. Seems that other themes do suffer such problems, such as the elements and green themes. I fixed all of them already, and a quick note you forgot to mention that messages.php has the same css flaw as myadopts.php and profile.php. It is present whenever pagination is used.

Looks like the css font size glitch only applies to the main theme, the green theme is unaffected. Weird, but its somewhat interesting to investigate.

I actually only just figured out the messages.php one while I was testing the notification thing. xD But I fixed it there too. It could possibly even work for the profile itself, but that doesn't resolve the ID missing thing.

Quote:

Originally Posted by Hall of Famer (Post 22712)

I think I had this issue in 1.3.0 as well - I just tested and I don't have it now, but it sounds familiar.

I did add in some modifications but not to the levelup script.

Are you sure about that? If so, send me the levelup.php and the modified files on your site so I may see what was the cause of your problem. Also investigate into the table prefix.voters and see if anything appears abnormal there.

Nothing looks weird there I don't think.....
Only thing I changed here is the is_numeric thing. But I changed that on my other site and it never messed it up.
levelup.php

Code:

<?php



include("functions/functions.php");

include("functions/functions_users.php");

include("functions/functions_adopts.php");

include("inc/lang.php");





//***************//

//  START SCRIPT //

//***************//



$id = $_GET["id"];

$id = preg_replace("/[^a-zA-Z0-9s]/", "", $id);

$id = secure($id);



if($id == ""){



// If the ID is blank or non-numeric, then it is invalid...



$article_title = $err_idnoexist;

$article_content = $err_idnoexist_text;



}

else{



// We have what appears to be a valid adoptable ID, so we pull the adoptable's information from the database...

$owned_adoptable = $adopts->select("owned_adoptables", array(), "aid='{$id}'")->fetchObject();        

if($owned_adoptable->aid == $id){



// The adoptable does exist, so now we need to see if we can vote...

// We need to get the date today and the user's IP address (if is guest we use this)



$date = date('Y-m-d');



$ip = $_SERVER['REMOTE_ADDR']; 

$ip = preg_replace("/[^a-zA-Z0-9@._-]/", "", $ip);

$ip = secure($ip);



$where_clause = ($isloggedin == "yes")

                ?"adoptableid='{$id}' and username = '{$loggedinname}' and date = '{$date}'"

                                :"adoptableid='{$id}' and ip = '{$ip}' and date = '{$date}'";

$voters = $adopts->select("vote_voters", array(), $where_clause)->fetchObject();        

$userstatus = getuserstatus($loggedinname);





  if($isloggedin == "yes" and $userstatus['canlevel'] == "no") $article_content .= "It appears that you have been banned from leveling up adoptables. Please contact an administrator for assistance.";   

  elseif(!is_object($voters)){



        // The number of results is still zero, so we did not vote on this adoptable yet today...

        

        // Now we see if the adoptable is frozen by its owner.  If it is, we do not level...



        if($owned_adoptable->isfrozen == "yes"){



        $article_title = $lang_isfrozen_title;

        $article_content = $lang_isfrozen_explain;



        }

        else{



          // Adoptable is NOT frozen, so I think we can actually proceed with the leveling up of this adoptable...

          $newclicks = $owned_adoptable->totalclicks + 1; // Add 1 click to the current click total of this adoptable...



          // Actually insert our click information into the database...

      $adopts->update("owned_adoptables", array("totalclicks" => $newclicks), "aid='{$id}'");



          // Now we need to update our vote_voters table with the user's vote...

          $adopts->insert("vote_voters", array("void" => NULL, "date" => $date, "username" => $loggedinname, "ip" => $ip, "adoptableid" => $id));



          // Now we need to see if we actually level this adoptable up, see if another level actually exists...



          $nextlevelexists = getnextlevelexists($owned_adoptable->type, $owned_adoptable->currentlevel);



          if($nextlevelexists == "true"){



            // A higher level does exist, so we see if it is time to level up

            $nextlevel = $owned_adoptable->currentlevel + 1;

        $level = $adopts->select("levels", array(), "adoptiename='{$owned_adoptable->type}' and thisislevel='{$nextlevel}'")->fetchObject();        

        

            // Check if the number of clicks we have now is greater than or equal to the required clicks to level up...

            if($newclicks >= $level->requiredclicks and $level->requiredclicks != 0 and $level->requiredclicks != ""){



              // We need to level this adoptable up...

              $adopts->update("owned_adoptables", array("currentlevel" => $nextlevel), "aid='{$id}'");

        

              // Now we check if we are enabling alternate images...        

              $parentid = converttypetoparentid($owned_adoptable->type); // Get the ID of the parent type adoptable

              $altstatus = getaltstatus($parentid, $id, $nextlevel); // Check if we are using alternate images or not...



              if($altstatus == "yes") $adopts->update("owned_adoptables", array("usealternates" => 'yes'), "aid='{$id}'");

              // Now we can see if the adoptable's owner gets a reward, the reward function will take care of sending out any reward that exists...

              $rewardstatus = reward($id, $owned_adoptable->type, $nextlevel, $owned_adoptable->owner);

            } // End the if statement if we are leveling the adoptable up        

          }



          // Show a thank you message along with the adoptable's information to the user...

          $image = getcurrentimage($id); // Get the current image of the adoptable...

          $article_title = $lang_gave."{$owned_adoptable->name} one ".$lang_unit;

          $article_content = "<img src='{$image}'><br>{$lang_gave}{$owned_adoptable->name}        one {$lang_unit}.<br>".$lang_levelup_encourage;        

        } // Adoptable is not frozen, end isfrozen else check

 

    if($owned_adoptable->isfrozen == "no"){ 

          $reward = clickreward(grabanysetting('rewardmoney'), $GLOBALS['username'], $GLOBALS['money']);

          $newamount = $GLOBALS['money'] + $reward;

          $adopts->update("users", array("money" => $newamount), "username = '{$loggedinname}'");

          $article_content = $article_content . "<div align='center'><br />You have earned {$reward} ".grabanysetting('cost')." for leveling up this adoptable. <br />You now have {$newamount} ".grabanysetting('cost')."</div>";

    }



  }

  else{



        // We already voted on this adoptable today, so show an error...



        if($isloggedin == "yes"){

                $article_title = $lang_alreadyleveled_title;

                $article_content = $lang_member_alreadyleveled;

        }

        else{

                $article_title = $lang_alreadyleveled_title;;

                $article_content = $lang_guest_alreadyleveled;

        }

  }

}

else{



// Adoptable is invalid, show an error...



$article_title = $err_idnoexist;

$article_content = $err_idnoexist_text;



}







} // End the ID is not blank and is numeric else check





//***************//

//  OUTPUT PAGE  //

//***************//



echo showpage($article_title, $article_content, $date);



?>

Yeah, it does not look any different from mine. Id recommend you to debug the codes then, and see if any variables are assigned with incorrect values. Assume you have not clicked a pet, the object $voters should be nonexistent and the property $voters->void should be absent. Now find this line:

PHP Code:


		
			
$article_content = $lang_member_alreadyleveled;

Replace with:

PHP Code:


		
			
$article_content = $lang_member_alreadyleveled;     
$article_content .= "The record is stored as {$voters->void} in the voters table.";

Give a try on your site and see what message you receive.

Ok clicked one and it let me level: You already leveled this adoptable today. You may only level an adoptable once per day. Please come back tomorrow to level this adoptable again.The record is stored as 547 in the voters table.

Clicked another and got this (that I hadn't leveled)
ou already leveled this adoptable today. You may only level an adoptable once per day. Please come back tomorrow to level this adoptable again.The record is stored as 39 in the voters table.

I see, now it is possible that something is wrong with your table prefix.voters, the very last one from your database. Take a look at the row with void '39' and '547', chances are the record of you clicking on these adoptables were already stored in database. Its weird though, no way it should occur with the way I designed the script...

Should I empty it?

Derp. It was the adoptid. You know how I have letters? Forgot to change it in that db :/

Ah I see. I did some test myself and it seems to be working too, glad you figured it out on your own. At least, well, I know for sure this is not a glitch with the new script. I was quite worried before. XD

Darn me and my need for letter codes :D Everyone is ok with the site re install. The new pound features are really neat and I saved everyone's dragons so it's all good. But now I have to get use to another new way of coding, lol. How do I join tables?

I see, glad it works out nicely, thought your members will be angry at the fact that they have to start over again. I do recommend you to be careful next time, you have an active site running already so the cost of rebuilding your site is immensely high compared to those who do not have much activity going on.

Actually the old code still works, you can write $query = "' and run it with $adopts->query(). Thats the beauty of the database class, it has backward compatibility. The new methods are really easy to use though, if you want to learn. The below code demonstrates such an example:

PHP Code:


		
			
$row = $adopts->join("users_status", "users_status.uid = users.uid")->join("users_profile", "users_profile.uid = users.uid")
                ->join("users_options", "users_options.uid = users.uid")->join("users_contacts", "users_contacts.uid = users.uid")
                ->select("users", array(), constant("PREFIX")."users.username = '{$user}'")->fetchObject();

So the script means you are joining the table users, users_contacts, users_options, users_profile and users_status with records that share the same user id, the where clause is username = $user. Note the current join() method has a tiny bit of problem, as you have to use ".constant('PREFIX')." in the statement. The idea of this database class is to get rid of having to play with table prefixes though, and we will fix it soon.

Hmm having some issues with it. I want to join owned_adoptables and adoptables... not sure really how to write it out though. I need currentlevel from owned_adoptables and description, hatchdescript, hatchmdescript and adult descript from adoptables.

The code should look like this:

PHP Code:


		
			
$pet = $adopts->join("adoptables", "adoptables.type = owned_adoptables.type")->select("owned_adoptables", array(), constant("PREFIX")."owned_adoptables.aid = '{$aid}'")->fetchObject();

The script means that you are joining tables adoptables and owned_adoptables by referencing the field 'type', which is supposed to be the same for each row fetched from database. The new script allows you to chain class methods by fetching object or array directly after a select query is used, so you do not need to write separate lines for mysql select codes. After applying the codes above, all you have to do is to retrieve the properties such as:

PHP Code:


		
			
$pet->id //The adoptables species id from table prefix.adoptables
$pet->description // The adoptables species description from table prefix.adoptables
$pet->currentlevel // The adoptables currentlevel from table prefix.owned_adoptables
$pet->totalclicks // The adoptables totalclicks from table prefix.owned_adoptables

If you want to join another table, just use the join() method twice in the script and chain them with select() and fetchObject() methods, it will work out nicely too.

And btw the script now wont autoban your user unless they try to adopt pets that have been taken away from pound center one day ago or earlier. In future I may improve this performance by allowing admins to determine how long this 'session' is going to be. Of course if you have a user trying to adopt a pet that has been adopted one day ago, he/she is most likely a cheater/hacker using inspect element(unless he/she takes a day to adopt a pound pet, which is stupid I say?). XD

I did everything you said to do to upgrade my sire from 1.3.0 to 1.3.1 and something is wrong :\ Everytime I try to login it just says I have a programing error...help?!

Snapshot: http://www.iaza.com/work/120410C/iaza18671524773200.png

Code of Login Page:

Quote:

<?php

include("functions/functions.php");
include("functions/functions_users.php");
include("inc/lang.php");

//***************//
// START SCRIPT //
//***************//

if($isloggedin == "yes"){

$article_title = $langislog;
$article_content = $langislogfull;

}
else{

//User is not logged in, so let's attempt to log them in...

$username = $_POST["username"];
$username = secure($username);
$password = $_POST["password"];
$password = secure($password);
$salt = $_POST["salt"];
$salt = secure($salt);

//User is not logged in

$loginform = "<form name='form1' method='post' action='login.php'>
<p>Username:
<input name='username' type='text' id='username'>
</p>
<p>Password:
<input name='password' type='password' id='password'>
</p>
<p>
<input type='submit' name='Submit' value='Submit'>
</p>
<p>Don't have an account?<br>
<a href='register.php'>Register Free</a> </p>
<a href='forgotpass.php'>Forgot your password? Click Here</a>
</form>";

if($loggedinname == "" and $password == ""){
// User is viewing login form
$article_title = "Member Login:";

$article_content = $loginform;
}
else if(($username != "" and $password == "") or ($username == "" and $password != "") ){

//Something was left blank
$article_title = "Login Error:";
$article_content = "Something was left blank. Please try logging in again.<br><br>{$loginform}";

}
else if($username != "" and $password != ""){
// Try to log the user in

$user = $adopts->select("users", array(), "username = '{$username}'")->fetchObject();
$password = passencr($username, $password, $user->salt);

if($username == $user->username and $password == $user->password){
$article_title = "Login Successful!";
$article_content = "Welcome back {$username}. You are now logged in. <a href='account.php'>Click Here to view or edit your account.</a>";

// Set the cookie
$Month = 2592000 + time();
// Convert from username to uid to secure data, no need for password since it is already hashed.
$uid = usernametouid($username);
$session = session_id();
$myssession = md5($uid.$session);
setcookie("mysuid",$uid,$Month);
setcookie("myssession",$myssession,$Month);

// Now update the user login session
$adopts->update("users", array("session" => $myssession), "username = '{$username}'");

// Time for forum-integration check
include("inc/config_forums.php");
if($mybbenabled == 1){
include_once("functions/functions_forums.php");
$forums = new Database($mybbdbname, $mybbhost, $mybbuser, $mybbpass, $mybbprefix) or die("Cannot connect to forum database, please contact an admin immediately.");
$mybbuser = $forums->select("users", array("uid", "loginkey"), "username = '{$username}'")->fetchObject();
$cookiesettings = array();
$cookiesettings['cookiedomain'] = $forums->select("settings", array("value"), "name = 'cookiedomain'")->fetchColumn();
$cookiesettings['cookiepath'] = $forums->select("settings", array("value"), "name = 'cookiepath'")->fetchColumn();
$cookiesettings['cookieprefix'] = $forums->select("settings", array("value"), "name = 'cookieprefix'")->fetchColumn();
mybbsetcookie("mybbuser", $mybbuser->uid."_".$mybbuser->loginkey, NULL, true, $cookiesettings);

$mybbsid = mybb_random_str(32);
mybbsetcookie("sid", $mybbsid, -1, true);
}
}
else{
$article_title = "Login Failed!";
$article_content = "Sorry, we could not log you on with the details specified. You can <a href='login.php'>try again</a> or <a href='forgotpass.php'>request a password reset.</a>";
$fail = 1;
}
}

}

//***************//
// OUTPUT PAGE //
//***************//

echo showpage($article_title, $article_content, $date);

?>

No, what I'm trying to do is if an adopt is a certain currentlevel, then show a certain description...

Code:

if($row->currentlevel == '6') {

$article_content .="<p align='justify'>{$row->adultdescript}";

}else if($row->currentlevel == '5') {

$article_content .="<p align='justify'>{$row->hatchmdescript}";

}else if($row->currentlevel == '4') {

$article_content .="<p align='justify'>{$row->hatchdescript}";

}else if($row->currentlevel <= '3') {

$article_content .="<p align='justify'>{$row->description}";

}

@KaceKuma:
This is strange, your server does not tell you what the error may be? If so, check your root directory and see if there is a file called error_log being generated. Copy/Paste the last lines and I will see what errors you are getting. Chances are you are missing some files. Note if your database table structure differs from a Mys v1.3.0 fresh install, theres no way to upgrade with the simple upgrader. In such a case, do it manually.

@Silverdragontears:
Yeah, I do not see the difference here besides you need to replace $pet by $row, unless you have another table storing pets descriptions. If this is true, just join another table, plain and simple. The codes I just posted should work fine for ya.

0.e i don't see an error log...and I haven't editted the database either...
I went through to see if the other errors for the login page (I.E not entering in all feilds) worked and they did, but when I enter everything correctly it comes up with that screenshoted screen.
My site is: http://www.generationsaber.com/
If you would like to create an account and see...

I see, looks like I cannot register lol. Have you heavily modified your users table? If so, the upgrader will not work for you. Also check the files config.php and config_forum.php and see if anything is wrong in these files.

I pasted it in and it won't pull up the info.

Did you change $pet to $row? Also its better for you to start a new thread asking for questions unrelated to installing/upgrading Mys v1.3.1 here.

No my config and forum config both looked filled out and fine. Again I really haden't messed with any of the script or db in fear that something like this would happen when I upgraded. I took a screenie of my adopts_users table as well...I'm veryconfused on what's happening and don't really want to have to wipe my site with other users on it...

Table Screenie: http://www.iaza.com/work/120410C/iaza18671541365100.png

I see, you were using an earlier version of Mys v1.3.0 that I replaced with an updated file two days later. The version(which I refer to as Mys v1.3.0 RC) you are using is missing a field called 'session' from table prefix.users, so you need to add it manually. The field should be placed between the field 'password' and 'email'. The field 'session' should be VARCHAR(100).

Alright...how should I fill this out (Like what should I put for the details and fill in for each user) and would that fix the problem? Also since I already ran the upgraded would that have messed with things? (*Is so clueless XD*)

Nope it will not mess up with things, your only problem appears to be the missing field from table prefix.users.

To accomplish this task, you need to go to the tab 'Structure' in Phpmyadmin. Now look at the screenshots below. The first one tells you how to add new field(note you must add the new field after the field 'password'!), the second one gives more detail on what values you should enter when phpmyadmin asks you to add a new field.

http://oi44.tinypic.com/2wfu1rk.jpg

Beautiful! It works fine now, thanks HoF!

You are very welcome, glad it works.

Small notice;
"Open the file /inc/config_forum.php"
It's
"Open the file /inc/config_forums.php"

;)

Thanks for pointing this out. In fact the reason why I changed it from config_forum.php to config_forums.php is that I plan on possibilities of integrating more than just MyBB. In future, users will need to select a forum engine they wish to integrate with their sites, although MyBB is highly recommended over other forum engines such as PhpBB, SMF and PunBB. Integrating with commercial forumwares such as Vbulletin, IPB and XenForo is also possible, but will most likely come out as premium Mod.

So I just set up a few shops and I don't see the item I put in one of my shops... It was the Breed1... what should the value be? Maybe that was my error.

Derp. I spelled the shop name wrong. Nm :D

What should the value be? Says I can't use it on a dragon that I should be able to?

Also the chance of an item is suppose to be random yet everytime it's telling me it failed. Sometimes it tells me that the item can't be used then when I try it again it tells me that it failed.... EVERY time. It's set at 50. Also I still can't get the breed1 to work.

Well this does not happen to me though, are you sure it is set to be 50? I set the chance to be barely 30 and it works on my adoptables like once per three tries.

Hmm.... I'm sure. Maybe it's my letter codes? I dont know... I mean for the click1 it sometimes says my luck sucks or whatever, or it says I can't use it. For breed1 and alts1 I can't ever use it.

Edit: It works for click2, but not the others.

umm thats strange. My breeding soup(breed1) has only 30% chance to take effect, and I've just tested it a moment ago. It worked 2 out of 3 times, so Id suppose it is indeed working. Did you set the target to 'all'? This aint supposed to be a problem for Mys v1.3.1 as I've set 'all' to be default value incase people make mistakes. Also make sure you do not enter numbers like 0.5 or 0.3 instead of 50 or 30.

breed1 works.... it's alts1 and clicks1 that I'm having issues with. I meant clicks not breed

Edit: Set it to all and it works... why doesn't it work when you put in the adopt ids?

Well I tested it on my site and the click1 item worked, the chance was set to be 80% and it took effect 1 out of 2 times(not sure if it would be 8 out of 10 if I had attempted 10 times lol). The Alt1 function does seem a bit glitchy, I will figure this out later.