Hey,
Wow didn't realize my post had been noted here so fast.
I realize I got increasingly sarcastic throughout the post, but I was being honest on my view of it, and I had listed plenty of examples.
I also, like before, realize that some of these issues aren't your fault, but after all they are being released under your name. I'm glad to hear you're working on them for the next release.
In my strong opinion, globals often mean that code was designed 'wrong'. There's always a better way to achieve what you want without using globals. I can understand if the way the code is setup makes it hard to transition from globals, but it's still being released with them and I was asked to give an honest review.
The jab at the encryption was mostly at how dramatic it was. There's easier ways to obtain equally secure encryption. I would call that secure, but how you encrypted it is just odd, not common at all, which just might make it more secure overall anyway.
Good luck, I'll keep checking it out every few releases.
NBS
|