Forum registeration

[Hall of Famer]

Well I am a bit confused here... Is registration not working for you and your members at all? Or are you only getting these messages out of nowhere while you can register and login?

[ChibiMaestro]

Registration is fine. It's just that the message appears when you register on the register.php page at the top.

[Hall of Famer]

Are you sure about this? The registration and login system appear to be fine on both of your adoptables site and forum? If so, post your register.php and I will tell you how to fix it. Looks like the problem is with inclusion path of library files.

[ChibiMaestro]

Okay, here it is:

<?php

include("functions/functions.php");
include("functions/functions_users.php");
include("inc/config_forums.php");
include("inc/lang.php");

//***************//
//  START SCRIPT //
//***************//

if($isloggedin == "yes"){

$article_title = "You already have an account";
$article_content = "You already have an account, thus there is no need for you to register a new one.";

}
else{

//Grab the post data from the form

$username = $_POST["username"];
$username = secure($username);
$pass1 = $_POST["pass1"];
$pass1 = secure($pass1);
$pass2 = $_POST["pass2"];
$pass2 = secure($pass2);
$email = $_POST["email"];
$ip = $_POST['ip'];
$birthday = $_POST['birthday'];
$avatar = $_POST["avatar"];
$tos = $_POST["tos"];
$hidden = $_POST["hidden"];
$answer = $_POST["answer"];
$answer2 = $_POST["answer2"];

  if($hidden != "goregister"){

	//The form was not submitted, so we are showing the signup page...
    $question = grabanysetting("securityquestion");
    $answer = grabanysetting("securityanswer");
	$article_title = $regnew;
	$article_content = $regnewexplain."<br><form name='form1' method='post' action='register.php'>
  	<p>Username: <input name='username' type='text' id='username' maxlength='20'></p>
  	<p>Your username may be up to 20 characters long and may only contain letters, numbers and spaces. </p>
  	<p>Password: <input name='pass1' type='password' id='pass1' maxlength='20'></p>
  	<p>Your password may be up to 20 characters long and may contain letters, numbers, spaces and special characters. The use of a special character, such as * or ! is recommended for increased security. </p>
  	<p>Confirm Password: <input name='pass2' type='password' id='pass2' maxlength='20'></p>
  	<p>Email Address: <input name='email' type='text' id='email'></p>
	<p>Birthday(mm/dd/yyyy): <input name='birthday' type='text' id='birthday'></p>
  	<p>Avatar url: <input name='avatar' type='text' id='avatar' value='templates/icons/default_avatar.gif'></p>
    <p>Security Question: {$question}
    <input name='answer' type='hidden' id='answer' value='{$answer}'></p>
    <p>Answer: <input name='answer2' type='text' id='answer2'></p>
  	<p><input name='tos' type='checkbox' id='tos' value='yes'> I agree to the <a href='tos.php' target='_blank'>Terms of Service</a>. 
  	<input name='ip' type='hidden' id='ip' value='{$_SERVER['REMOTE_ADDR']}'></p>
	<input name='hidden' type='hidden' id='hidden' value='goregister'></p>
  	<p><input type='submit' name='Submit' value='Register'>
  	</p></form>";


  }
  else{

	//We are attempting to register the user...
	
    $salt = codegen(15, 0);
	$password1 = passencr($username, $pass1, $salt);
	$password2 = passencr($username, $pass2, $salt);

	//Next check that the username does not already exist...

	$flag = 0;
	$row = $adopts->select("users", array(), "username = '{$username}'")->fetchObject();
	if(is_object($row)) $flag = 1;
	//Now we verify that the email address is a valid email address...
	$emailisvalid = "no";
    $regex = '/^[A-Z0-9._%+-]+@[A-Z0-9.-]+\.[A-Z]{2,4}$/i'; 
	
	if(preg_match($regex, $email)) $emailisvalid = "yes";
	
	//First check that something required was not left blank...

	if($username == "" or $password1 == "" or $password2 == "" or $email == ""){
	   $article_title = "Error";
	   $article_content = $regblank;
	}
	else if($password1 != $password2){
	
	   //Passwords do not match
	   $article_title = "Your passwords do not match";
	   $article_content = $passnomatch;
	}
	else if($tos != "yes"){

	   //User did not agree to TOS
	   $article_title = "Terms of Service Error";
	   $article_content = $notos;
	}
	else if($flag > 0){
	
	   //Username already exists
	   $article_title = "Your username already exists";
	   $article_content = $userexists;	
	}
	else if($emailisvalid != "yes"){

	    //Email address is not valid or is a fake
	   $article_title = "Email address is not valid";
	   $article_content = $emailinvalid;
	}
	else if($answer != $answer2){

	   //Email address is not valid or is a fake
	   $article_title = "An error has occurred";
	   $article_content = "It seems that you did not answer the security question correctly...";
	}
	else{

	   //All checks are done, actually create the user's account on the database

	   $date = date('Y-m-d');
	   $session = session_id();
       $myssession = md5($uid.$session);
	   $adopts->insert("users", array("uid" => NULL, "username" => $username, "salt" => $salt, "password" => $password1, "session" => $myssession, "email" => $email, "ip" => $_SERVER['REMOTE_ADDR'], 
			                          "usergroup" => 3, "birthday" => $birthday, "membersince" => $date, "money" => $GLOBALS['settings']['startmoney'], "friends" => NULL));
	
       $adopts->insert("users_contacts", array("uid" => NULL, "username" => $username, "website" => NULL, "facebook" => NULL, "twitter" => NULL, 
	                                           "aim" => NULL, "yahoo" => NULL, "msn" => NULL, "skype" => NULL));
	
	   $adopts->insert("users_options", array("uid" => NULL, "username" => $username, "newmessagenotify" => 1, "pmstatus" => 0, 
	                                          "vmstatus" => 0, "tradestatus" => 0, "theme" => $GLOBALS['settings']['theme']));

       $adopts->insert("users_profile", array("uid" => NULL, "username" => $username, "avatar" => $avatar, "bio" => NULL, "color" => NULL, 
	                                          "about" => NULL, "favpet" => 0, "gender" => 'unknown', "nickname" => NULL));											  
	
	   $adopts->insert("users_status", array("uid" => NULL, "username" => $username, "canlevel" => 'yes', "canvm" => 'yes', "canfriend" => 'yes', 
	                                         "cantrade" => 'yes', "canbreed" => 'yes', "canpound" => 'yes', "canshop" => 'yes'));	
		
       //Now check if Mybb forum integration is enabled
       if($mybbenabled == 1){
           //Mybb forum integration is enabled, now generate the user account on Mybb forum!
           include("functions/functions_forums.php");
           $forums = new Database($mybbdbname, $mybbhost, $mybbuser, $mybbpass, $mybbprefix) or die("Cannot connect to forum database, please contact an admin immediately.");

           //Now the database has been switched to mybb forum's. Before inserting user info, lets generate the password and salt in Mybb format.
           $salty = codegen(8, 0);
           $loginkey = codegen(50, 0);
           $md5pass = md5($pass1);
           $fpass = md5(md5($salty).$md5pass); 
           $ip = $_SERVER['REMOTE_ADDR'];
           $altip = ipgen($ip);  
           $query = "INSERT INTO {$mybbprefix}users (uid, username, password, salt, loginkey, email, postnum, avatar, avatardimensions, avatartype, usergroup, additionalgroups, displaygroup, usertitle, regdate, lastactive, lastvisit, lastpost, website, icq, aim, yahoo, msn, birthday, birthdayprivacy, signature, allownotices, hideemail, subscriptionmethod, invisible, receivepms, receivefrombuddy, pmnotice, pmnotify, threadmode, showsigs, showavatars, showquickreply, showredirect, ppp, tpp, daysprune, dateformat, timeformat, timezone, dst, dstcorrection, buddylist, ignorelist, style, away, awaydate, returndate, awayreason, pmfolders, notepad, referrer, referrals, reputation, regip, lastip, longregip, longlastip, language, timeonline, showcodebuttons, totalpms, unreadpms, warningpoints, moderateposts, moderationtime, suspendposting, suspensiontime, suspendsignature, suspendsigtime, coppauser, classicpostbit, loginattempts, failedlogin, usernotes)
                                                                               VALUES ('', '$username', '$fpass','$salty','$loginkey','$email', '0', '', '', '0', '2', '', '0', '', 'time()', 'time()', 'time()', '0', '', '', '', '', '', '$birthday', 'all', '', '1', '0', '0', '0', '1', '0', '1', '1', '', '1', '1', '1', '1', '0', '0', '0', '', '', '0', '0', '0', '', '', '0', '0', '0', '', '', '', '', '0','0','0','$ip', '$ip','$altip','$altip','','0','1', '0', '0', '0','0','0','0','0','0','0','0','0','1','0','')";
           $forums->query($query) or die("Failed to create forum account");

           // Now set the cookie for user on MyBB        
           $mybbuser = $forums->select("users", array("uid", "loginkey"), "username = '{$username}'")->fetchObject();
           $cookiesettings = array();
           $cookiesettings['cookiedomain'] = $forums->select("settings", array("value"), "name = 'cookiedomain'")->fetchColumn();
           $cookiesettings['cookiepath'] = $forums->select("settings", array("value"), "name = 'cookiepath'")->fetchColumn();
           $cookiesettings['cookieprefix'] = $forums->select("settings", array("value"), "name = 'cookieprefix'")->fetchColumn();
           mybbsetcookie("mybbuser", $mybbuser->uid."_".$mybbuser->loginkey, NULL, true, $cookiesettings);

           $mybbsid = mybb_random_str(32); 
           mybbsetcookie("sid", $mybbsid, -1, true); 
       }    

	   //Now that we have created the user, let's log them in...

	   $status = dologin($username, $password1, $myssession);

	   if($status != "success"){
	
	      $article_title = "Something is Wrong!";
	      $article_content = "Something is very, very wrong.  Please contact Mysidia Adoptables about this error.";

	   }
	   else{

	   //We are registered and logged in...
	   $article_title = $titleregsuccess;
	   $article_content = $regsuccess."".$username."".$regsuccess2;

       if($mybbenabled == 1) $article_content .= "</br></br>You may also visit your forum account and edit your profile."; 

	   //Reflect our changes in the sidebar... 
	   $sidebar = "<b><u>Welcome {$username}</u></b>:<br><a href='account.php'>Go to My Account</a><br><a href='adopt.php'>Adopt Some Pets</a>";

	   }
	}
	


  }

}

//***************//
//  OUTPUT PAGE  //
//***************//

echo showpage($article_title, $article_content, $date);

?>

[Hall of Famer]

Well I see the problem is not with register.php... Open your functions.php and find this line

PHP Code:

include("../inc/config_forums.php"); 


Replace by:

PHP Code:

include("inc/config_forums.php"); 


This should fix your problem, I am not sure why this error is not displaying for my demo site though. It looks like a glitch, I will post it in bug tracker now.

[ChibiMaestro]

Woah. Magic. Yay ^-^ Thanks Hoffie!!!! It works without displaying any kind of weird messages!