Mysidia Adoptables Support Forum  

Home Community Mys-Script Creative Off-Topic
Go Back   Mysidia Adoptables Support Forum > Mysidia Adoptables > Questions and Supports

Notices

Reply
 
Thread Tools Display Modes
  #1  
Old 03-16-2015, 02:54 PM
NobodysHero's Avatar
NobodysHero NobodysHero is offline
Co-Owner of MystFell
 
Join Date: Nov 2013
Posts: 144
Gender: Female
Credits: 18,404
NobodysHero is on a distinguished road
Default Partial Trades Not Showing - MystFell.com

I've received several complaints from my users (And have tested this out myself) that they're not able to view their partial trades. They get a notification that they have a trade from a user, but when they go to the page it's blank. Is there somewhere else they should be going?
Reply With Quote
  #2  
Old 12-10-2015, 08:50 AM
tahbikat's Avatar
tahbikat tahbikat is offline
Member
 
Join Date: Feb 2014
Location: Louisiana
Posts: 408
Gender: Female
Credits: 48,901
tahbikat is on a distinguished road
Default

Don't mean to bump an old thread but I'm having sorta the same problem. Whenever users send trades to each other they get the PM in their inboxes but when they go to their My Trades it doesn't show anything. Anyone found a solution?
Reply With Quote
  #3  
Old 12-10-2015, 10:25 AM
Hall of Famer's Avatar
Hall of Famer Hall of Famer is offline
Administrator, Lead Coder
 
Join Date: Dec 2008
Location: South Brunswick
Posts: 4,448
Gender: Male
Credits: 327,379
Hall of Famer is on a distinguished road
Default

Well does this only apply for partial trades, or is it not working for any kinds of trades(private and public too)?
__________________


Mysidia Adoptables, a free and ever-improving script for aspiring adoptables/pets site.
Reply With Quote
  #4  
Old 12-10-2015, 01:59 PM
tahbikat's Avatar
tahbikat tahbikat is offline
Member
 
Join Date: Feb 2014
Location: Louisiana
Posts: 408
Gender: Female
Credits: 48,901
tahbikat is on a distinguished road
Default

I tested it out and it seems as though if a user selects partial trade, without specifying a creature, it gets sent to the Partial Trades page instead of My Trades page.

Whereas if partial trade ISN'T selected, it gets sent to My Trades like it's supposed to.

When I accepted a trade from My Trades page, it threw up an error page saying "an item wasn't selected" but when I went to check my adopts, the trade did in fact go through.

Public trades also aren't working. They show up in the public trades list, but when I tried offering a trade to one of the public ones, it gives me an error saying something like "You cannot specify a trade recipient in a public trade!" even though the recipient is automatically already specified. :x


So all in all the system is kind of working like it's supposed to aside from the public trades, though it's kind of confusing.
Reply With Quote
  #5  
Old 12-10-2015, 11:18 PM
Hall of Famer's Avatar
Hall of Famer Hall of Famer is offline
Administrator, Lead Coder
 
Join Date: Dec 2008
Location: South Brunswick
Posts: 4,448
Gender: Male
Credits: 327,379
Hall of Famer is on a distinguished road
Default

I see, I will take a look into this. Its very strange, I tested the script before and never had the same problem. I will see what I can come out with.
__________________


Mysidia Adoptables, a free and ever-improving script for aspiring adoptables/pets site.
Reply With Quote
  #6  
Old 12-10-2015, 11:54 PM
tahbikat's Avatar
tahbikat tahbikat is offline
Member
 
Join Date: Feb 2014
Location: Louisiana
Posts: 408
Gender: Female
Credits: 48,901
tahbikat is on a distinguished road
Default

Alrighty, thank you! ^^
Reply With Quote
  #7  
Old 12-11-2015, 04:52 AM
Hall of Famer's Avatar
Hall of Famer Hall of Famer is offline
Administrator, Lead Coder
 
Join Date: Dec 2008
Location: South Brunswick
Posts: 4,448
Gender: Male
Credits: 327,379
Hall of Famer is on a distinguished road
Default

You are right, this does appear to be a bug. Its very strange since the public trade used to be working, and it was introduced in Mys v1.3.4 so nothing should've broken it. I will test the script again later today and let you know the fix I find.

Edit:
Found the fix, it was a glitch. Just one line of code will fix the public trade issue. To do this, go to script file trade.php in your root directory, and locate line 71:

PHP Code:
$validator $this->trade->getValidator("public"); 
Change to:

PHP Code:
$validator $this->trade->getValidator("private"); 
This should make your public trades work again. As you can see from the code above, when you reply to a public trade offer, you are in fact sending a private trade to the original poster(although your options may be limited, as the poster may specify exactly what he/she wants from a certain adoptable/item type). For this reason, the validator should validate the trade as a private trade, rather than another public trade. Hope this makes sense to you.

Also I've attached trade.php file in this post, you may just download it and replace your own trade.php file through ftp.
Attached Files
File Type: php trade.php (5.7 KB, 0 views)
__________________


Mysidia Adoptables, a free and ever-improving script for aspiring adoptables/pets site.
Reply With Quote
  #8  
Old 12-11-2015, 11:02 AM
tahbikat's Avatar
tahbikat tahbikat is offline
Member
 
Join Date: Feb 2014
Location: Louisiana
Posts: 408
Gender: Female
Credits: 48,901
tahbikat is on a distinguished road
Default

Ahh thanks so much HoF! That was quick! <3
I'll add this to my site and test it out!

EDIT: Yikes, so I'm not sure if it's working because I'm getting other errors now for some reason.

Whenever I try to make a public trade, it says "Fatal error occured, that species doesn't seem to exist in database"

Also, when I try to revise one of my own public trades, it gives me an error saying "That user doesn't seem to exist"

Last edited by tahbikat; 12-11-2015 at 11:10 AM.
Reply With Quote
  #9  
Old 12-11-2015, 11:07 AM
Hall of Famer's Avatar
Hall of Famer Hall of Famer is offline
Administrator, Lead Coder
 
Join Date: Dec 2008
Location: South Brunswick
Posts: 4,448
Gender: Male
Credits: 327,379
Hall of Famer is on a distinguished road
Default

You are very welcome. ^^ Note the solution fixes public trades, I havent looked into partial trades since your last post was a bit confusing on whether there was a bug or not with partial trade. If there is, I will fix that too.
__________________


Mysidia Adoptables, a free and ever-improving script for aspiring adoptables/pets site.
Reply With Quote
  #10  
Old 12-11-2015, 11:22 AM
tahbikat's Avatar
tahbikat tahbikat is offline
Member
 
Join Date: Feb 2014
Location: Louisiana
Posts: 408
Gender: Female
Credits: 48,901
tahbikat is on a distinguished road
Default

Oh I edited my reply above. For some reason public trades aren't working at all now. :x Haven't tested the others
Reply With Quote
Reply

Tags
partial trades, trade, trades

Thread Tools
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump

Similar Threads
Thread Thread Starter Forum Replies Last Post
MystFell: A Celtic/Norse Themed Pet Site! NobodysHero Adoptables Buzz 6 12-25-2013 12:31 PM
One Sided Trades GuardiansWish Questions and Supports 16 04-28-2013 05:50 PM
I'm showing up more then once AlkseeyaKC Questions and Supports 21 08-28-2011 02:52 AM
Can offer negative money on trades tittlemouse Questions and Supports 7 03-24-2011 10:34 AM
Not Showing Name SJC Questions and Supports 4 04-21-2009 05:03 AM


All times are GMT -5. The time now is 07:54 AM.

Currently Active Users: 441 (0 members and 441 guests)
Threads: 4,080, Posts: 32,024, Members: 2,016
Welcome to our newest members, jolob.
BETA





What's New?

What's Hot?

What's Popular?


Powered by vBulletin® Version 3.8.11
Copyright ©2000 - 2024, vBulletin Solutions Inc.
vBCommerce I v2.0.0 Gold ©2010, PixelFX Studios
vBCredits I v2.0.0 Gold ©2010, PixelFX Studios
Emoticons by darkmoon3636